powerpc64-ibm-aix: fix cfg(target_abi) value#153830
powerpc64-ibm-aix: fix cfg(target_abi) value#153830RalfJung wants to merge 1 commit intorust-lang:mainfrom
Conversation
|
r? @jackh726 rustbot has assigned @jackh726. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
Makes sense, thanks for fixing this in the target spec! |
|
I do wonder why this was added in #102293 with an "extabi" value here... Cc @ecnelises in case you still remember. |
This comment has been minimized.
This comment has been minimized.
|
Without vec-extabi, v20-v31 cannot be used, so in most projects Clang enables this option. To align with it, we also enabled it by default. Maybe the IBM folks can explain it in more detail... |
You didn't, though? You set Some inline asm tests are failing now though. I'm a bit surprised b y that -- whether functions can use registers internally and whether the ABI uses them are usually separate questions, aren't they? |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Closing in favor of #153876 -- clearly there's more going on here than I understand, so I shouldn't be changing the code. I hope someone I pinged in that issue will be able to help. :) |
We don't actually use the ExtAbi currently, see #153784. So fix the value of cfg(target_abi) to match reality.
Cc @Gelbpunkt @daltenty @gilamn5tr @amy-kwan