Skip to content

remove concept of soft-unstable features#153622

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
RalfJung:rm-soft-unstable
Mar 17, 2026
Merged

remove concept of soft-unstable features#153622
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
RalfJung:rm-soft-unstable

Conversation

@RalfJung
Copy link
Member

@RalfJung RalfJung commented Mar 9, 2026

Implements rust-lang/compiler-team#972

@rust-lang/libs-api last chance to speak up before this feature is gone :)

Fixes #153572
Fixes #64266

@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2026

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 9, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2026

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 15 candidates

@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
JonathanBrouwer
JonathanBrouwer approved these changes Mar 9, 2026
View reviewed changes
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup

View changes since this review

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 9, 2026

📌 Commit 59dfb9e has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2026
@RalfJung
Copy link
Member Author

RalfJung commented Mar 9, 2026

@bors r-

Let's wait a bit longer to see if we hear anything from libs-api

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 9, 2026
@joshtriplett joshtriplett added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Mar 12, 2026
@joshtriplett
Copy link
Member

joshtriplett commented Mar 12, 2026

@RalfJung I've added I-libs-api-nominated; we should be able to talk about this and respond in next week's meeting.

@RalfJung RalfJung added S-waiting-on-t-libs Status: Awaiting decision from T-libs and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 12, 2026
@nia-e
Copy link
Member

nia-e commented Mar 17, 2026

+1 from @rust-lang/libs-api, thanks!

@rustbot label -I-libs-api-nominated

@rustbot rustbot removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Mar 17, 2026
@RalfJung
Copy link
Member Author

RalfJung commented Mar 17, 2026

All right then, let's go. :)
@bors r=JonathanBrouwer

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 17, 2026

📋 This PR cannot be approved because it currently has the following label: S-waiting-on-t-libs.

@RalfJung RalfJung removed the S-waiting-on-t-libs Status: Awaiting decision from T-libs label Mar 17, 2026
@RalfJung
Copy link
Member Author

RalfJung commented Mar 17, 2026

@bors r=JonathanBrouwer

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 17, 2026

📌 Commit 59dfb9e has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 17, 2026
@Amanieu
Copy link
Member

Amanieu commented Mar 17, 2026

The most recent time we would have used this is in #149978, for which we used a FCW instead. So there is no longer any need for this lint.

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 17, 2026
@JonathanBrouwer
Rollup merge of rust-lang#153622 - RalfJung:rm-soft-unstable, r=Jonat…
3003148 
…hanBrouwer

remove concept of soft-unstable features

Implements rust-lang/compiler-team#972

@rust-lang/libs-api last chance to speak up before this feature is gone :)

Fixes rust-lang#153572
Fixes rust-lang#64266
This was referenced Mar 17, 2026
Closed
Merged
rust-bors bot pushed a commit that referenced this pull request Mar 17, 2026
@bors
Auto merge of #154008 - JonathanBrouwer:rollup-tfGnRi2, r=JonathanBro…
85e19b8 
…uwer

Rollup of 14 pull requests

Successful merges:

 - #153972 (stdarch subtree update)
 - #153801 (Add the option to run UI tests with the parallel frontend)
 - #153959 (Fix non-module `parent_module` in stripped cfg diagnostics)
 - #153967 (Tweak wording of failed predicate in inference error)
 - #152968 (Flip "region lattice" in RegionKind doc comment)
 - #153531 (Fix LegacyKeyValueFormat report from docker build: various)
 - #153622 (remove concept of soft-unstable features)
 - #153709 (Fix hypothetical ICE in `variances_of`)
 - #153884 (test `classify-runtime-const` for `f16`)
 - #153894 (Point at unit structs on foreign crates in type errors when they are the pattern of a binding)
 - #153920 (improve `#[track_caller]` invalid ABI error)
 - #153946 (dissolve `tests/ui/cross`)
 - #153965 (Fix minor kasan bugs)
 - #153991 (Small report_cycle refactor)
@rust-bors rust-bors bot merged commit 626f9d3 into rust-lang:main Mar 17, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 17, 2026
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Mar 18, 2026
@bors
Auto merge of #154008 - JonathanBrouwer:rollup-tfGnRi2, r=JonathanBro…
bac802d 
…uwer

Rollup of 14 pull requests

Successful merges:

 - rust-lang/rust#153972 (stdarch subtree update)
 - rust-lang/rust#153801 (Add the option to run UI tests with the parallel frontend)
 - rust-lang/rust#153959 (Fix non-module `parent_module` in stripped cfg diagnostics)
 - rust-lang/rust#153967 (Tweak wording of failed predicate in inference error)
 - rust-lang/rust#152968 (Flip "region lattice" in RegionKind doc comment)
 - rust-lang/rust#153531 (Fix LegacyKeyValueFormat report from docker build: various)
 - rust-lang/rust#153622 (remove concept of soft-unstable features)
 - rust-lang/rust#153709 (Fix hypothetical ICE in `variances_of`)
 - rust-lang/rust#153884 (test `classify-runtime-const` for `f16`)
 - rust-lang/rust#153894 (Point at unit structs on foreign crates in type errors when they are the pattern of a binding)
 - rust-lang/rust#153920 (improve `#[track_caller]` invalid ABI error)
 - rust-lang/rust#153946 (dissolve `tests/ui/cross`)
 - rust-lang/rust#153965 (Fix minor kasan bugs)
 - rust-lang/rust#153991 (Small report_cycle refactor)
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Mar 18, 2026
@bors
Auto merge of #154008 - JonathanBrouwer:rollup-tfGnRi2, r=JonathanBro…
6201d57 
…uwer

Rollup of 14 pull requests

Successful merges:

 - rust-lang/rust#153972 (stdarch subtree update)
 - rust-lang/rust#153801 (Add the option to run UI tests with the parallel frontend)
 - rust-lang/rust#153959 (Fix non-module `parent_module` in stripped cfg diagnostics)
 - rust-lang/rust#153967 (Tweak wording of failed predicate in inference error)
 - rust-lang/rust#152968 (Flip "region lattice" in RegionKind doc comment)
 - rust-lang/rust#153531 (Fix LegacyKeyValueFormat report from docker build: various)
 - rust-lang/rust#153622 (remove concept of soft-unstable features)
 - rust-lang/rust#153709 (Fix hypothetical ICE in `variances_of`)
 - rust-lang/rust#153884 (test `classify-runtime-const` for `f16`)
 - rust-lang/rust#153894 (Point at unit structs on foreign crates in type errors when they are the pattern of a binding)
 - rust-lang/rust#153920 (improve `#[track_caller]` invalid ABI error)
 - rust-lang/rust#153946 (dissolve `tests/ui/cross`)
 - rust-lang/rust#153965 (Fix minor kasan bugs)
 - rust-lang/rust#153991 (Small report_cycle refactor)
@RalfJung RalfJung deleted the rm-soft-unstable branch March 18, 2026 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanBrouwer JonathanBrouwer JonathanBrouwer approved these changes

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

Tracking issue for MCP 972: Remove soft_unstable Tracking issue for future-incompatibility lint soft_unstable

7 participants

@RalfJung @rustbot @rust-log-analyzer @joshtriplett @nia-e @Amanieu @JonathanBrouwer