Move try_to_bits from Const to Valtree#136130
Closed
FedericoBruzzone wants to merge 1 commit intorust-lang:masterfrom
Closed
Move try_to_bits from Const to Valtree#136130FedericoBruzzone wants to merge 1 commit intorust-lang:masterfrom
try_to_bits from Const to Valtree#136130FedericoBruzzone wants to merge 1 commit intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #135158
What's in this PR?
try_to_bits: Transitioned fromConsttoValtree.validate_const_with_value: Renamed toextract_valtree_and_tyfor better clarity.Benefits
Valtreeavoids the need to re-evaluate aConst, improving efficiency where this re-evaluation was previously performed. For instance, in:TooGenericvariant toLayoutErrorand emitUnknown#135158).r? @lukas-code @oli-obk