compiletest: Remove the -test suffix from normalize directives#134759
Merged
bors merged 3 commits intorust-lang:masterfrom Dec 27, 2024
Merged
compiletest: Remove the -test suffix from normalize directives#134759bors merged 3 commits intorust-lang:masterfrom
-test suffix from normalize directives#134759bors merged 3 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This suffix was an artifact of using the same condition-checking engine as the
ignore-*andonly-*directives, but in practice we have only 2 tests that legitimately use a condition, and both of them only care about 32-bit vs 64-bit.This PR detaches
normalize-*directives from the condition checker, and replaces it with a much simpler system of four explicitNormalizeKindvalues. It then takes advantage of that simplicity to get rid of the-testsuffix.Addresses one of the points of #126372.
The new name-checking code is a bit quaint, but I think it's a definite improvement over the status quo.
The corresponding dev-guide update is rust-lang/rustc-dev-guide#2172.
r? jieyouxu