Delegation: support coercion for target expression#126699
Merged
bors merged 1 commit intorust-lang:masterfrom Jul 17, 2024
Merged
Delegation: support coercion for target expression#126699bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(solves #118212 (comment))
The implementation consist of 2 parts. Firstly, method call is generated instead of fully qualified call in AST->HIR lowering if there were no generic arguments or
Qpathwere provided. These restrictions are imposed due to the loss of information after desugaring. For example inWe would like to generate such a code:
however, the signature is inherited during HIR analysis where
u8was discarded.Then, we probe the single pre-resolved method.
P.S In the future, we would like to avoid restrictions on the callee path by
Selfautoref/autoderef in fully qualified calls, but at the moment it didn't work out.r? @petrochenkov