Improve diagnostic output of non_local_definitions lint#125089
Merged
bors merged 11 commits intorust-lang:masterfrom May 28, 2024
Merged
Improve diagnostic output of non_local_definitions lint#125089bors merged 11 commits intorust-lang:masterfrom
non_local_definitions lint#125089bors merged 11 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves (or at least tries to improve) the diagnostic output of
non_local_definitionslint, by simplifying the wording, by adding a "sort of" explanation of bounds interaction that leak the impl...This PR is best reviewed commit by commit and is voluntarily made a bit vague as to have a starting point to improve on.
Related to https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/non_local_defs.20wording.20improvements
Fixes #125068
Fixes #124396
cc @workingjubilee
r? @estebank