Stop skewing inference in ?'s desugaring#122412
Closed
WaffleLapkin wants to merge 4 commits intorust-lang:masterfrom
Closed
Stop skewing inference in ?'s desugaring#122412WaffleLapkin wants to merge 4 commits intorust-lang:masterfrom
WaffleLapkin wants to merge 4 commits intorust-lang:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NB: this is a breaking change (although arguably a bug fix) and as such shouldn't be taken lightly.
This changes
expr?'s desugaring like so (simplified, see code for more info):This prevents
!from thereturnfrom skewing inference:Fixes #51125
Closes #39216