Support tail calls in mir via TerminatorKind::TailCall#113128
Merged
bors merged 15 commits intorust-lang:masterfrom Jul 8, 2024
Merged
Support tail calls in mir via TerminatorKind::TailCall#113128bors merged 15 commits intorust-lang:masterfrom
TerminatorKind::TailCall#113128bors merged 15 commits intorust-lang:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one of the interesting bits in tail call implementation — MIR support.
This adds a new
TerminatorKindwhich represents a tail call:Structurally this is very similar to a normal
Callbut is missing a few fields:destination— tail calls don't write to destination, instead they pass caller's destination to the callee (such that eventualreturnwill write to the caller of the function that used tail call)target— similarly todestinationtail calls pass the caller's return address to the callee, so there is nothing to dounwind— I think this is applicable too, although it's a bit confusingcall_source—becomeforbids operators and is not created as a lowering of something else; tail calls always come from HIR (at least for now)It might be helpful to read the interpreter implementation to understand what
TailCallmeans exactly, although I've tried documenting it too.There are a few
FIXME-questions still left, ideally we'd be able to answer them during review ':)r? @oli-obk
cc @scottmcm @drmeepster @JakobDegen