Stop handling opaque types in queries and leave it to typeck#107891
Closed
oli-obk wants to merge 4 commits intorust-lang:masterfrom
Closed
Stop handling opaque types in queries and leave it to typeck#107891oli-obk wants to merge 4 commits intorust-lang:masterfrom
oli-obk wants to merge 4 commits intorust-lang:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some cleanups now that all the lazy TAIT work has settled down.
We do not need to look into queries anymore, as all the opaque types get "equated away" early enough so that the trait solvers don't see opaque types unless they should treat them opaquely.
The last commit additionally flips the default on
infcx.at(...).eqand friends, requiring you to opt-in to registering hidden types. We can probably do more cleanups here and possibly manage to eliminate theInferCtxt::defining_use_anchorfield entirely by doing all processing at thedefine_opaque_typessites.r? @lcnr