Fix syntax in -Zunpretty-expanded output for derived PartialEq.#107488
Merged
bors merged 1 commit intorust-lang:masterfrom Feb 2, 2023
Merged
Fix syntax in -Zunpretty-expanded output for derived PartialEq.#107488bors merged 1 commit intorust-lang:masterfrom
-Zunpretty-expanded output for derived PartialEq.#107488bors merged 1 commit intorust-lang:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you do
derive(PartialEq)on a packed struct, the output shown by-Zunpretty=expandedincludes expressions like this:This is invalid syntax. This doesn't break compilation, because the AST nodes are constructed within the compiler. But it does mean anyone using
-Zunpretty=expandedoutput as a guide for hand-written impls could get a nasty surprise.This commit fixes things by instead using this form:
r? @RalfJung