Support #[track_caller] on async fns#104219
Merged
bors merged 6 commits intorust-lang:masterfrom Nov 17, 2022
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
#[track_caller]to the generator that is created when we desugar the async fn.Fixes #78840
Open questions:
#[track_caller]to everyGenFuture'spoll(...)function, even if it's unused (i.e., the parent span does not set#[track_caller])? We might need to set it only conditionally, if the indirection causes overhead we don't want.