This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Merged
Conversation
eddyb
reviewed
May 17, 2018
| fn late_callback( | ||
| &mut self, | ||
| trans_crate: &TransCrate, | ||
| trans_crate: &CodegenBackend, |
Contributor
There was a problem hiding this comment.
This should probably be renamed to codegen_backend.
nrc
reviewed
May 17, 2018
| clippy = ["clippy_lints"] | ||
|
|
||
| [patch.crates-io] | ||
| rls-rustc = { git = 'https://github.com/alexcrichton/rls-rustc', branch = 'fix' } |
Member
There was a problem hiding this comment.
I've published 0.3 with your changes now
Member
Author
|
Updated! |
Member
|
Thanks! |
Member
|
Testing a PR for updating RLS in the Rust repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RLS is broken by rust-lang/rust#50615 and rust-dev-tools/rls-rustc#8 is also required to merge this