Avoid linting unreachable_code on todo!()#3928
Open
llogiq wants to merge 2 commits intorust-lang:masterfrom
Open
Avoid linting unreachable_code on todo!()#3928llogiq wants to merge 2 commits intorust-lang:masterfrom
unreachable_code on todo!()#3928llogiq wants to merge 2 commits intorust-lang:masterfrom
Conversation
Contributor
Author
|
Note that rust#149543 has an implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
todo!()is often used as a placeholder while working on the code, we should avoid lintingunreachable_codeon code after those macro uses. Instead let's add atodo_macro_useslint that we can selectively activate e.g. when compiling a release.This will reduce message churn and allow users to concentrate on the warnings and errors that matter while they work on the code.
Rendered