Add vendor-specific suffixes to v0 mangling RFC 2603#3224
Merged
michaelwoerister merged 1 commit intorust-lang:masterfrom Mar 22, 2022
Merged
Add vendor-specific suffixes to v0 mangling RFC 2603#3224michaelwoerister merged 1 commit intorust-lang:masterfrom
michaelwoerister merged 1 commit intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates v0 mangling to add an Itanium ABI-like vendor-specific suffix to symbols.
This already happens in practice (e.g. with LLVM LTO to ensure a name is globally unique) and the demanglers following the spec strictly can't handle these symbols. This PR makes them officially part of the spec.
The vendor-specific suffix is optional and doesn't change semantics: it is IMO safe to ignore in the vast majority of cases.
Improvements to the wording and description would be welcome. Opening the PR for possible discussion at today's t-compiler meeting, and possible FCP later.
cc @michaelwoerister