Integrate with the team repo#267
Merged
Centril merged 7 commits intorust-lang:masterfrom Mar 31, 2019
emilyalbini:team-repo
Merged
Integrate with the team repo#267Centril merged 7 commits intorust-lang:masterfrom emilyalbini:team-repo
Centril merged 7 commits intorust-lang:masterfrom
emilyalbini:team-repo
Conversation
Centril
reviewed
Mar 31, 2019
| let de: ToDeserialize = ::reqwest::get(url)? | ||
| .error_for_status()? | ||
| .json()?; | ||
| self.cached_teams = de.teams; |
Contributor
There was a problem hiding this comment.
Note to self: rust-lang/rfcs#2522 would have been handy here.
Member
Author
|
Addressed all review comments, and fixed CI failing. |
Centril
reviewed
Mar 31, 2019
Contributor
Centril
left a comment
Centril
left a comment
There was a problem hiding this comment.
Looks good; just a nit :)
Centril
reviewed
Mar 31, 2019
Centril
reviewed
Mar 31, 2019
| thread::sleep(sleep_duration); | ||
| } | ||
| }) | ||
| pub fn start_scraping() -> Option<JoinHandle<()>> { |
Contributor
There was a problem hiding this comment.
Note to self (i.e. please ignore for PR review purposes), cc Centril/rfcs#17.
This would have been so nice with:
pub fn start_scraping() -> Option<JoinHandle<()>> = try {
spawn_thread("GitHub scraper", CONFIG.github_interval_mins?, || try {
scrape_github(github::most_recent_update()?);
})
};
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @Centril