Re-export core::ffi integer types rather than redefining#5015
Merged
tgross35 merged 1 commit intorust-lang:mainfrom Mar 14, 2026
Merged
Re-export core::ffi integer types rather than redefining#5015tgross35 merged 1 commit intorust-lang:mainfrom
core::ffi integer types rather than redefining#5015tgross35 merged 1 commit intorust-lang:mainfrom
Conversation
3 tasks
tgross35
added
the
stable-nominated
tgross35
force-pushed
the
core-ffi-types
branch
from
e7881e1 to
eb5bdf7
Compare
tgross35
force-pushed
the
core-ffi-types
branch
2 times, most recently
from
5358562 to
c2839d1
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
|
I think you can remove this test too, since I think it's just testing that libc types match std types: https://github.com/rust-lang/libc/blob/main/libc-test/tests/primitive_types.rs |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Since the MSRV was raised to 1.65, we can use these aliases directly rather than copying them. In a future version, we can consider deprecation.
tgross35
force-pushed
the
core-ffi-types
branch
from
c2839d1 to
9a4b8c6
Compare
Contributor
Author
|
Good call! Removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the MSRV was raised to 1.65, we can use these aliases directly rather than copying them. In a future version, we can consider deprecation.