Skip to content

config: add test showing error in Config::from_str() usage#1226

Open
DanielEScherzer wants to merge 1 commit intorust-lang:masterfrom
DanielEScherzer:cfg_from_str_borken
Open

config: add test showing error in Config::from_str() usage#1226
DanielEScherzer wants to merge 1 commit intorust-lang:masterfrom
DanielEScherzer:cfg_from_str_borken

Conversation

@DanielEScherzer
Copy link
Contributor

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: Waiting on review label Mar 12, 2026
@DanielEScherzer
Copy link
Contributor Author

@rustbot label +bug "help wanted"
This was intended to show that the code from #1225 has some problem somewhere - I spent a few hours trying to debug it and came up empty, some uses of the config work fine and others result in tcache_thread_shutdown(): unaligned tcache chunk detected
@ehuss should #1225 be reverted for now?

@ehuss
Copy link
Contributor

ehuss commented Mar 12, 2026

Yea, let's go ahead and revert. Looking more closely, git_config_backend_from_string is part of the "sys" API which I do not believe is intended to be part of the public API.

I think I see what's causing the memory corruption, so I'll file an issue with libgit2. But since it is an internal API, we probably shouldn't be exposing it here.

@rustbot
Copy link
Collaborator

rustbot commented Mar 12, 2026

☔ The latest upstream changes (possibly #1227) made this pull request unmergeable. Please resolve the merge conflicts.

@DanielEScherzer
Copy link
Contributor Author

I think I see what's causing the memory corruption, so I'll file an issue with libgit2

Would appreciate a link to that, I wasn't able to figure out the cause

@ehuss
Copy link
Contributor

ehuss commented Mar 12, 2026

Here's the upstream issue: libgit2/libgit2#7219

@DanielEScherzer
Copy link
Contributor Author

DanielEScherzer commented Mar 13, 2026

@rustbot label "-help wanted" -S-waiting-on-review +S-blocked +upstream

Lets wait until the upstream issue is resolved, and then I'll investigate trying to re-add the ::from_str() method

@rustbot
Copy link
Collaborator

rustbot commented Mar 13, 2026

Error: Parsing relabel command in comment failed: ...' label -' | error: quote in word at >| '"help want'...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

@rustbot rustbot added S-blocked Status: Marked as blocked on further work upstream An upstream issue with libgit2 and removed S-waiting-on-review Status: Waiting on review help wanted labels Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug S-blocked Status: Marked as blocked on further work upstream An upstream issue with libgit2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants