sitemaps: add "recent" sitemap, use last-build-date instead of release date#3259
Open
syphar wants to merge 1 commit intorust-lang:mainfrom
Open
sitemaps: add "recent" sitemap, use last-build-date instead of release date#3259syphar wants to merge 1 commit intorust-lang:mainfrom
syphar wants to merge 1 commit intorust-lang:mainfrom
Conversation
Member
syphar
commented
Mar 17, 2026
syphar
commented
- in case of rebuilds, we previously didn't update the dates in the sitemap, which means there weren't (quickly) re-crawled.
- I saw some recommendation to provide a separate "recent" sitemap, which would make google crawl fresh or updated entries earlier.
github-actions
bot
added
the
S-waiting-on-review
| .map(|days| { | ||
| today | ||
| .checked_sub_days(Days::new(days)) | ||
| .expect("underflow when building recent sitemap dates") |
Member
There was a problem hiding this comment.
Instead of panicking, couldn't we return an error?
| { | ||
| return Err(AxumNope::ResourceNotFound); | ||
| } | ||
| fn render_sitemap_item(item: SitemapItem) -> AxumResult<Bytes> { |
Member
There was a problem hiding this comment.
Wouldn't it be better to call this function with SitemapItemXml directly?
| if letter.len() != 1 { | ||
| return Err(AxumNope::ResourceNotFound); | ||
| } else if let Some(ch) = letter.chars().next() | ||
| && !(ch.is_ascii_lowercase()) |
Member
There was a problem hiding this comment.
I don't think the parens are needed after ! here, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.