mark in-progress builds as canceled when we restart#3250
Merged
GuillaumeGomez merged 1 commit intorust-lang:mainfrom Mar 15, 2026
Merged
mark in-progress builds as canceled when we restart#3250GuillaumeGomez merged 1 commit intorust-lang:mainfrom
GuillaumeGomez merged 1 commit intorust-lang:mainfrom
Conversation
github-actions
bot
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Mar 15, 2026
Member
|
Thanks! |
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves an annoyance that existed since I added #2533.
When I want to update the docs.rs binaries, and would just run
update-docs.rs, then we have leftoverin-progressrecords in thebuildstable. Our process would just exit. The build itself was fine, since postgres would just unlock the record, and another builder (or this one, restarted) would pick it up again.But: the in-progress record would stay in the database.
This is a small workaround for this. The queue guarantees that these only can be one build for each release, so we can simply mark existing in-progress build records as error.
This doesn't solve the issue that we'll still have the old
docker runprocess running in the background, but that's for a separate PR.Note: this issue would have become a bigger one with more automatic deployments for the new infra.