Skip to content

Add cr_hypot from CORE-MATH#859

Merged
tgross35 merged 2 commits intorust-lang:mainfrom
tgross35:core-hypot
Mar 31, 2026
Merged

Add cr_hypot from CORE-MATH#859
tgross35 merged 2 commits intorust-lang:mainfrom
tgross35:core-hypot

Conversation

@tgross35
Copy link
Copy Markdown
Contributor

@tgross35 tgross35 commented Apr 20, 2025 •
edited
Loading

ci: allow-regressions

@tgross35 tgross35 mentioned this pull request Apr 20, 2025
Closed
@tgross35 tgross35 marked this pull request as ready for review February 12, 2026 09:45
@rustbot

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 31, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@tgross35 tgross35 force-pushed the core-hypot branch 2 times, most recently from f207099 to a00038c Compare March 31, 2026 07:09
@tgross35 tgross35 changed the title Add cr_hypot from core-math Add cr_hypot from CORE-math Mar 31, 2026
@tgross35
Copy link
Copy Markdown
Contributor Author

tgross35 commented Mar 31, 2026

Pretty even regressions across the board:

icount::icount_bench_hypot_group::icount_bench_hypot logspace:setup_hypot()
Performance has regressed: Instructions (16883 -> 80417) regressed by +376.319% (>+5.00000%)
  Baselines:                      softfloat|softfloat (old)
  Instructions:                       80417|16883                (+376.319%) [+4.76319x]
  L1 Hits:                            94339|18383                (+413.186%) [+5.13186x]
  LL Hits:                                2|2                    (No change)
  RAM Hits:                              40|18                   (+122.222%) [+2.22222x]
  Total read+write:                   94381|18403                (+412.857%) [+5.12857x]
  Estimated Cycles:                   95749|19023                (+403.333%) [+5.03333x]

i686:

icount::icount_bench_hypot_group::icount_bench_hypot logspace:setup_hypot()
Performance has regressed: Instructions (43985 -> 190027) regressed by +332.027% (>+5.00000%)
  Baselines:                      softfloat|softfloat (old)
  Instructions:                      190027|43985                (+332.027%) [+4.32027x]
  L1 Hits:                           253001|57357                (+341.099%) [+4.41099x]
  LL Hits:                                5|1                    (+400.000%) [+5.00000x]
  RAM Hits:                              72|27                   (+166.667%) [+2.66667x]
  Total read+write:                  253078|57385                (+341.018%) [+4.41018x]
  Estimated Cycles:                  255546|58307                (+338.277%) [+4.38277x]

x86-64

icount::icount_bench_hypot_group::icount_bench_hypot logspace:setup_hypot()
Performance has regressed: Instructions (21615 -> 106197) regressed by +391.312% (>+5.00000%)
  Baselines:                      softfloat|softfloat (old)
  Instructions:                      106197|21615                (+391.312%) [+4.91312x]
  L1 Hits:                           122095|24257                (+403.339%) [+5.03339x]
  LL Hits:                                4|4                    (No change)
  RAM Hits:                              50|23                   (+117.391%) [+2.17391x]
  Total read+write:                  122149|24284                (+403.002%) [+5.03002x]
  Estimated Cycles:                  123865|25082                (+393.840%) [+4.93840x]

@tgross35 tgross35 enabled auto-merge (rebase) March 31, 2026 07:30
@tgross35 tgross35 changed the title Add cr_hypot from CORE-math Add cr_hypot from CORE-MATH Mar 31, 2026
@tgross35
Copy link
Copy Markdown
Contributor Author

tgross35 commented Mar 31, 2026 •
edited
Loading

Oh, way better on the hardfloat options. Aarch64:

icount::icount_bench_hypot_group::icount_bench_hypot logspace:setup_hypot()
Performance has regressed: Instructions (14447 -> 18946) regressed by +31.1414% (>+5.00000%)
  Baselines:                      hardfloat|hardfloat (old)
  Instructions:                       18946|14447                (+31.1414%) [+1.31141x]
  L1 Hits:                            20360|15623                (+30.3207%) [+1.30321x]
  LL Hits:                                1|0                    (+++inf+++) [+++inf+++]
  RAM Hits:                              15|7                    (+114.286%) [+2.14286x]
  Total read+write:                   20376|15630                (+30.3647%) [+1.30365x]
  Estimated Cycles:                   20890|15868                (+31.6486%) [+1.31649x]

i686:

icount::icount_bench_hypot_group::icount_bench_hypot logspace:setup_hypot()
Performance has regressed: Instructions (37475 -> 192906) regressed by +414.759% (>+5.00000%)
  Baselines:                      hardfloat|hardfloat (old)
  Instructions:                      192906|37475                (+414.759%) [+5.14759x]
  L1 Hits:                           262984|49721                (+428.919%) [+5.28919x]
  LL Hits:                                7|5                    (+40.0000%) [+1.40000x]
  RAM Hits:                              68|14                   (+385.714%) [+4.85714x]
  Total read+write:                  263059|49740                (+428.868%) [+5.28868x]
  Estimated Cycles:                  265399|50236                (+428.304%) [+5.28304x]

x86-64

icount::icount_bench_hypot_group::icount_bench_hypot logspace:setup_hypot()
Performance has regressed: Instructions (18297 -> 38446) regressed by +110.122% (>+5.00000%)
  Baselines:                      hardfloat|hardfloat (old)
  Instructions:                       38446|18297                (+110.122%) [+2.10122x]
  L1 Hits:                            51224|20615                (+148.479%) [+2.48479x]
  LL Hits:                                3|3                    (No change)
  RAM Hits:                              35|11                   (+218.182%) [+3.18182x]
  Total read+write:                   51262|20629                (+148.495%) [+2.48495x]
  Estimated Cycles:                   52464|21015                (+149.650%) [+2.49650x]

@tgross35 tgross35 merged commit 5d10ee1 into rust-lang:main Mar 31, 2026
44 checks passed
@tgross35 tgross35 deleted the core-hypot branch March 31, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tgross35 @rustbot