chore: Update htslib to 1.23#32
Open
killercup wants to merge 9 commits intorust-bio:mainfrom
Open
Conversation
seems like this does nothing, cf. https://docs.rs/cc/1.2.56/cc/struct.Build.html#method.static_flag
it's nice one, the first to support 2021 edition. Could probably go older but I just wanted to make it explicit
shows up on https://lib.rs/crates/hts-sys/features for example
htslib 1.23 merged hfile_s3_write.c into hfile_s3.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the hts submodule to version 1.23 (see https://github.com/samtools/htslib/releases/tag/1.23) and also update the prebuilt bindings.
Along the way, I also change a bunch of other things, e.g. making the minimum Rust version explicit and removing the static feature as
ccalways sets this now.