feat: initial runealytics plugin

[mrtms]

No description provided.

[runelite-github-app]

Includes changes by non-author

New plugin runealytics: https://github.com/Runescape-Tracking/RuneAlytics-Plugin/tree/04707a5031dc19f266798494ffde3ba02244f8db

[runelite-github-app]

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.

---

Internal use only: Reviewer details Maintainer details

[raiyni]

It looks like there is a difference between what you say this plug-in does and what it actually does. Eg what is this match making stuff?

[mrtms]

It looks like there is a difference between what you say this plug-in does and what it actually does. Eg what is this match making stuff?

It looks like there might be some confusion about what the plugin actually does.

This isn’t just a loot tracking & banking syncing plugin. It’s a multi-feature plugin.

It includes:

Loot tracking: When you kill an NPC and get a drop, the item is automatically tracked on your account and synced to our website.

Banking Sync - Syncs your OSRS bank to our website

Matchmaking (still being tested): We’re building a PvP matchmaking system that pairs you with players of similar skill level — kind of like how Gamebattles/MLG used to work. It’s still in testing and we’re ironing out the kinks.

Account verification: There’s also a verification system that links your in-game account to our website (runealytics.com).

[cshunton]

It looks like there is a difference between what you say this plug-in does and what it actually does. Eg what is this match making stuff?

Our next major update will include the full match making system but we have a little more testing to do with it before we make it live. Our goal is to allow players to select a specific type of PvP match that they enjoy to do, and learn how to perfect it and play against other players around the same skill as them. Once our system is complete, there will be an elo system that will help match skill set

[raiyni]

Why do you need bank contents and IGN, human please reply

[cshunton]

Why do you need bank contents and IGN, human please reply

The bank system is used to show off your loot, by default this is always off (not tracked and must be enabled by the user if they want to track it. On the site it is also defaulted to private so if the user select to sync banks then it must be also enabled on the site if they want the public to view it.

It goes hand in hand with out loot tracking system, it allows the website to track your GP gains if the user wants to

[mhollink]

Question from a bystander; doesn't this require a warning like wom-utils and such?

[cshunton]

Question from a bystander; doesn't this require a warning like wom-utils and such?

We can definitely add that

[cshunton]

Why do you need bank contents and IGN, human please reply

Was i able to answer your question?

[cshunton]

This is an example of the data the plugin uses to show off your drops/XP.

@mhollink

[mhollink]

.

What a passive agressieve way to ping the reviewers who are currently swamped in work 😒

[mrtms]

.

What a passive agressieve way to ping the reviewers who are currently swamped in work 😒

Chill out. He's new to GitHub and being a dev; he was on his phone and accidentally commented a .. It was edited once he noticed it, you were just quick with a response.

[LlemonDuck]

typo in my own suggestion, sorry

[mrtms]

typo in my own suggestion, sorry

All good! Committed the update!

[LlemonDuck]

do you intend for the default url to be a testing url? https://github.com/Runescape-Tracking/RuneAlytics-Plugin/blob/f4e2657ad857ac785eb4c79083133ebb4bfefb42/src/main/java/com/runealytics/RunealyticsConfig.java#L67

[mrtms]

do you intend for the default url to be a testing url? https://github.com/Runescape-Tracking/RuneAlytics-Plugin/blob/f4e2657ad857ac785eb4c79083133ebb4bfefb42/src/main/java/com/runealytics/RunealyticsConfig.java#L67

Nice catch and probably on the safer side if we do the main server rather than the testing one since that's where we deploy testing code to. Thanks for that - appreciate the thorough code review!

[000744210]

I notice you could make your bank stats public. Does that go against this?

Hiscores for PBs and other information not on the hiscores: Same as the GE Tracker, the data could easily be spoofed, rendering it useless

https://github.com/runelite/runelite/wiki/Rejected-or-Rolled-Back-Features

[LlemonDuck]

remove runelite-plugin.properties from /src/main/resources

gitignore /out while you're at it