Skip to content

Fix 16 missing dependencies and 1 excessive dependency in Makefile#102

Open
vemakereporter wants to merge 1 commit intorui314:masterfrom
vemakereporter:master
Open

Fix 16 missing dependencies and 1 excessive dependency in Makefile#102
vemakereporter wants to merge 1 commit intorui314:masterfrom
vemakereporter:master

Conversation

@vemakereporter
Copy link
Copy Markdown

Hi, I've fixed 16 missing dependencies and 1 excessive dependency reported.
Those issues can cause incorrect results or unnecessary rebuilds when 8cc is incrementally built.
For example, any changes in "main.c" will not cause "main.o" to be rebuilt, which is incorrect. The dependency rule in line 16 of the fixed Makefile can solve the dependence issues of 14 targets, including "vector.o", buffer.o", "path.o" and etc.
"8cc.h" is not read by the process when the target “utiltest" is built. Hence, the change of this file can cause an unnecessary rebuild of "utiltest", which slow down the build of the whole project.
I've tested it on my computer, the fixed version worked as expected.
Looking forward to your confirmation.

Thanks
Vemake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant