Reduce the Number of Migration Files#660
Open
TekuConcept wants to merge 4 commits intorubysherpas:rails4from
Open
Reduce the Number of Migration Files#660TekuConcept wants to merge 4 commits intorubysherpas:rails4from
TekuConcept wants to merge 4 commits intorubysherpas:rails4from
Conversation
Author
|
My bad, I stumbled upon the 'CONTRIBUTING.md' file several hours after creating this pull request. I am currently in the process of fixing those errors presented in the 'rspec spec' tests. |
Contributor
|
If you are talking about the Travis CI test failures then all of them are currently caused by Forem specifying s.add_dependency 'rails', '~> 4.0', '<= 4.2'in the gemspec even though there is no Rails 4.2 support right now. This means that the tests are run in the context of a Rails 4.2 app and results in a lot of errors. Rails 4.2 support and all the errors have been fixed but not yet pushed to Forem since there is a bug in Rails 4.2 that prevents the push. More details here: #640 |
Author
|
Good to know; I will push my updates based on the contribution standards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed when adding the forem engine to our website that there were a total of 32 migration files generated. I merged them into 9 individual table files and 1 user file.