Merged
Conversation
The first change is necessary for the example to work at all. The lower two changes are not strictly necessary though, but they may help when trying or copying parts of the example.
Contributor
|
Ugh, this is embarassing... Both for missing it initially, and for missing your PR for several months. Thank you for your help! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The classes were named inconsistently so that the examples would not work at all.
In the second commit, I also added the parent class to all class definitions to make it clearer what the parents are, even though this is not strictly necessary for any of the re-opened classes.