Skip to content

Em yank pop fix#867

Merged
ima1zumi merged 2 commits intoruby:masterfrom
tompng:em_yank_pop_fix
Mar 13, 2026
Merged

Em yank pop fix#867
ima1zumi merged 2 commits intoruby:masterfrom
tompng:em_yank_pop_fix

Conversation

@tompng
Copy link
Copy Markdown
Member

@tompng tompng commented Nov 19, 2025

Fix reline crash with em_yank_pop (#794 (comment))
Correct em_yank_pop key bindings.
Before: M-C-y and M-Y
After: M-y and M-Y

em_yank_pop should only work just after em_yank. Cursor movement and all other operation should abort yank-yank_pop.
This restriction will prevent yank_pop triggered in arbitrary line/byte_position that cause reline crash.

Add M-y and remove M-C-y.
M-y and M-Y are both yank_pop but M-C-y has no effect in both Emacs and GNU Readline.
Copy link
Copy Markdown
Member

@ima1zumi ima1zumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ima1zumi ima1zumi merged commit b047017 into ruby:master Mar 13, 2026
85 of 86 checks passed
@tompng tompng deleted the em_yank_pop_fix branch March 13, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants