Skip to content

Fix memory leak if ossl_bn_new() fails #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ndossche wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −1
Open

Fix memory leak if ossl_bn_new() fails #1010

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ext/openssl/ossl_asn1.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,12 @@ asn1str_to_str(const ASN1_STRING *str)
ASN1_STRING_length(str));
}

static VALUE
ossl_bn_new_wrap_i(VALUE arg)
{
return ossl_bn_new((BIGNUM *)arg);
}

/*
* ASN1_INTEGER conversions
*/
Expand All @@ -126,6 +132,7 @@ asn1integer_to_num(const ASN1_INTEGER *ai)
{
BIGNUM *bn;
VALUE num;
int st = 0;

if (!ai) {
ossl_raise(rb_eTypeError, "ASN1_INTEGER is NULL!");
Expand All @@ -137,9 +144,11 @@ asn1integer_to_num(const ASN1_INTEGER *ai)

if (!bn)
ossl_raise(eOSSLError, NULL);
num = ossl_bn_new(bn);
num = rb_protect(ossl_bn_new_wrap_i, (VALUE)bn, &st);
BN_free(bn);

if (st) rb_jump_tag(st);

return num;
}

Expand Down