Fix SLACK_FILE_UPLOAD with correct SLACK_TOKEN usage for files.upload#230
Open
DEVANSH-GAJJAR wants to merge 1 commit intortCamp:masterfrom
Open
Fix SLACK_FILE_UPLOAD with correct SLACK_TOKEN usage for files.upload#230DEVANSH-GAJJAR wants to merge 1 commit intortCamp:masterfrom
DEVANSH-GAJJAR wants to merge 1 commit intortCamp:masterfrom
Conversation
…e of the SLACK_BOT_TOKEN
Author
|
Hii there , i have submitted a PR to resolve the issue #178 . Please let me know if there is any changes to it needed . Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
SLACK_FILE_UPLOADlogic in the current code usesSLACK_BOT_TOKEN, but this variable is not always set or consistent with the rest of the workflow, which primarily usesSLACK_TOKEN.Solution
SLACK_BOT_TOKENwithSLACK_TOKENfor file upload authorization.SLACK_TOKEN.SLACK_TOKENis not provided.Related Issue
Closes #178