feat: Allow excluding the Github Actor from the message#112
Open
ondrosh wants to merge 1 commit intortCamp:masterfrom
Open
feat: Allow excluding the Github Actor from the message#112ondrosh wants to merge 1 commit intortCamp:masterfrom
ondrosh wants to merge 1 commit intortCamp:masterfrom
Conversation
|
Actually, I have successfully excluded it from the message by using |
|
Thanks @lazy-octopus-kebab , this works as a workaround: But merging this PR would definitely help us too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
There is currently no way to exclude the Github Actor from being in the message.
Solution
According to the Slack API documentation, the
author_linkandauthor_iconvalues only work ifauthor_nameis present.With
omitemptyspecified on theauthor_namewithin theAttachmentstructure, allowingSLACK_MSG_AUTHORto be an empty string will result in this field being unset which will allow users to choose if they want to exclude the Github Actor from being in the message.Changes
main.shto use=instead of:-on setting theGITHUB_ACTORwhich avoids empty strings being substitutedREADME.mdwith details on how to avoid including the Github Actor in the message