fix: remediate phpstan errors#149
Open
justlevine wants to merge 1 commit intoscaffold-eslint-fixesfrom
Open
Conversation
justlevine
force-pushed
the
scaffold-phpstan-errors
branch
from
104f525 to
9128827
Compare
justlevine
force-pushed
the
scaffold-phpstan-errors
branch
from
9128827 to
8505ddd
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses PHPStan analysis issues by adding WordPress stub definitions for OneSearch-specific dynamic properties and by fixing a typed-property initialization issue in the Search module.
Changes:
- Added a PHPStan stub file extending
WP_Query/WP_Postwith OneSearch dynamic properties. - Registered the new stub file in
phpstan.neon.dist. - Initialized
Search::$is_search_enabledtonullto avoid uninitialized typed-property problems.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
phpstan/stubs/wordpress-extended.php |
Adds PHPStan-only declarations for OneSearch dynamic properties on WP core types. |
phpstan.neon.dist |
Loads the new stub file during PHPStan analysis. |
inc/Modules/Search/Search.php |
Ensures nullable typed property is initialized to prevent uninitialized-property errors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes PHPStan errors in the repo.
Important
This PR is based on #148 which should be merged first.
Relevant diff: 104f525
Technical Details
OpenCode Promt
Checklist
Screenshots
To-do
Fixes/Covers issue
Fixes #