Skip to content

Chore: resolve vulnerabilities in transitive NPM dependencies#95

Merged
up1512001 merged 1 commit intodevelopfrom
chore/dependabot-issues
Mar 6, 2026
Merged

Chore: resolve vulnerabilities in transitive NPM dependencies#95
up1512001 merged 1 commit intodevelopfrom
chore/dependabot-issues

Conversation

@imrraaj
Copy link
Collaborator

@imrraaj imrraaj commented Mar 5, 2026

What

This PR adds overrides in package.json to address security vulnerabilities reported by Dependabot and npm audit.

Why

Fixes dependabot alerts

How

Testing Instructions

Screenshots

Additional Info

Checklist

  • I have read the Contribution Guidelines.
  • I have read the Development Guidelines.
  • My code is tested to the best of my abilities.
  • My code passes all lints (ESLint etc.).
  • My code has detailed inline documentation.
  • I have updated the project documentation as needed.

Copilot AI review requested due to automatic review settings March 5, 2026 15:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses reported security vulnerabilities in transitive NPM dependencies by adding npm overrides and bumping the plugin version to 1.1.2 across WordPress metadata files and changelog.

Changes:

  • Added additional overrides entries in package.json for vulnerable transitive dependencies.
  • Bumped plugin version from 1.1.1 to 1.1.2 in readme.txt and onedesign.php.
  • Added a 1.1.2 entry to CHANGELOG.md noting the security-related dependency work.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File Description
readme.txt Updates WordPress “Stable tag” to 1.1.2.
package.json Adds new overrides to force patched transitive dependency versions.
onedesign.php Updates plugin header version and ONEDESIGN_VERSION constant to 1.1.2.
CHANGELOG.md Documents the 1.1.2 security-related dependency change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 79 to +85
"overrides": {
"@babel/runtime": "^7.27.6",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"webpack-dev-server@<=5.2.0": ">=5.2.1"
"webpack-dev-server@<=5.2.0": ">=5.2.1",
"minimatch": ">=10.2.1",
"serialize-javascript": ">=7.0.3",
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json adds/changes overrides, but package-lock.json is not updated in this PR. With npm projects, the lockfile should be regenerated and committed so installs (and CI) are reproducible and actually reflect the overridden versions.

Copilot uses AI. Check for mistakes.
Comment on lines +83 to +93
"webpack-dev-server@<=5.2.0": ">=5.2.1",
"minimatch": ">=10.2.1",
"serialize-javascript": ">=7.0.3",
"@wp-playground/blueprints": {
"ajv": ">=8.18.0"
},
"@wp-playground/tools": {
"ajv": ">=8.18.0"
},
"@wp-playground/cli": {
"ajv": ">=8.18.0"
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several new override constraints are open-ended (e.g., >=5.2.1, >=10.2.1, >=7.0.3, >=8.18.0). Because these ranges have no upper bound, a future install could pull in a new major version and break the toolchain. Prefer pinning to a specific patched version (or at least constraining to the intended major, e.g. ^5.2.1 / ^10.2.1 / ^7.0.3 / ^8.18.0).

Suggested change
"webpack-dev-server@<=5.2.0": ">=5.2.1",
"minimatch": ">=10.2.1",
"serialize-javascript": ">=7.0.3",
"@wp-playground/blueprints": {
"ajv": ">=8.18.0"
},
"@wp-playground/tools": {
"ajv": ">=8.18.0"
},
"@wp-playground/cli": {
"ajv": ">=8.18.0"
"webpack-dev-server@<=5.2.0": "^5.2.1",
"minimatch": "^10.2.1",
"serialize-javascript": "^7.0.3",
"@wp-playground/blueprints": {
"ajv": "^8.18.0"
},
"@wp-playground/tools": {
"ajv": "^8.18.0"
},
"@wp-playground/cli": {
"ajv": "^8.18.0"

Copilot uses AI. Check for mistakes.
@imrraaj imrraaj requested a review from up1512001 March 6, 2026 08:50
@up1512001 up1512001 merged commit 5289f5e into develop Mar 6, 2026
10 of 13 checks passed
@up1512001 up1512001 deleted the chore/dependabot-issues branch March 6, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants