chore(deps): update Rspack to 2.0.0-beta.2#409
Merged
chenjiahan merged 6 commits intomainfrom Feb 24, 2026
Merged
Conversation
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a significant dependency upgrade for Rspack-related packages to version Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates Rspack to version 2.0.0-beta.2 across multiple packages, which is a significant and welcome update. The changes correctly follow the migration guide for Rspack v2, such as removing experiments.css and adding type: 'css' to module rules. I've pointed out a few package.json files where build-related dependencies could be moved to devDependencies for consistency and best practice. Overall, this is a great update.
Comment on lines
10
to
16
| "dependencies": { | ||
| "@rspack/cli": "1.7.6", | ||
| "@rspack/core": "1.7.6", | ||
| "@rspack/cli": "2.0.0-beta.2", | ||
| "@rspack/core": "2.0.0-beta.2", | ||
| "@rspack/dev-server": "1.2.1", | ||
| "monaco-editor": "^0.55.1", | ||
| "monaco-editor-webpack-plugin": "^7.1.1" | ||
| } |
There was a problem hiding this comment.
For consistency and best practice, build-related dependencies like @rspack/cli, @rspack/core, and @rspack/dev-server should be in devDependencies.
"dependencies": {
"monaco-editor": "^0.55.1",
"monaco-editor-webpack-plugin": "^7.1.1"
},
"devDependencies": {
"@rspack/cli": "2.0.0-beta.2",
"@rspack/core": "2.0.0-beta.2",
"@rspack/dev-server": "1.2.1"
}
Comment on lines
12
to
18
| "dependencies": { | ||
| "@rspack/cli": "1.7.6", | ||
| "@rspack/core": "1.7.6", | ||
| "@rspack/cli": "2.0.0-beta.2", | ||
| "@rspack/core": "2.0.0-beta.2", | ||
| "@rspack/dev-server": "1.2.1", | ||
| "lib1": "workspace:*", | ||
| "lib2": "workspace:*", | ||
| "typescript": "^5.9.3" |
There was a problem hiding this comment.
For consistency with other packages in this repository and general best practice, build-related dependencies like @rspack/cli, @rspack/core, @rspack/dev-server, and typescript should be in devDependencies rather than dependencies.
"dependencies": {
"lib1": "workspace:*",
"lib2": "workspace:*"
},
"devDependencies": {
"@rspack/cli": "2.0.0-beta.2",
"@rspack/core": "2.0.0-beta.2",
"@rspack/dev-server": "1.2.1",
"typescript": "^5.9.3"
}
Comment on lines
+11
to
+13
| "@rspack/cli": "2.0.0-beta.2", | ||
| "@rspack/core": "2.0.0-beta.2", | ||
| "@rspack/dev-server": "1.2.1", |
There was a problem hiding this comment.
For consistency and best practice, build-related dependencies like @rspack/cli, @rspack/core, and @rspack/dev-server should be moved to devDependencies.
There was a problem hiding this comment.
Pull request overview
Updates the Rspack examples in this monorepo to Rspack 2.0.0-beta.2 and applies required config changes for the Rspack v2 CSS handling/migration guide.
Changes:
- Bump
@rspack/cli/@rspack/corefrom1.7.6to2.0.0-beta.2across many example packages. - Add
@rspack/dev-server@1.2.1to example packages (to supportrspack devwith Rspack v2 CLI peer deps). - Remove
experiments.cssand migrate CSS handling tomodule.ruleswithtype: 'css'(and related variants) in multiple Rspack configs.
Reviewed changes
Copilot reviewed 121 out of 122 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rspack/worklet/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/worker/package.json | Move CLI to devDeps and bump to v2 beta; add dev-server. |
| rspack/worker-inline/package.json | Bump Rspack deps to v2 beta; bump worker loader; add dev-server. |
| rspack/workbox-webpack-plugin/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/webpack-stats-plugin/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/webpack-bundle-analyzer/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/wasm-simple/package.json | Move CLI to devDeps and bump to v2 beta; add dev-server. |
| rspack/vue/rspack.config.js | Remove experiments.css (CSS migration-related config change). |
| rspack/vue/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/vue-vanilla/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/vue-tsx/rspack.config.js | Replace experiments.css with explicit CSS rule. |
| rspack/vue-tsx/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/vue-jsx/rspack.config.js | Replace experiments.css with explicit CSS rule. |
| rspack/vue-jsx/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/vanilla-extract-css/rspack.config.js | Remove experiments.css (relies on existing CSS rule). |
| rspack/vanilla-extract-css/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/unplugin-auto-import/rspack.config.js | Replace experiments.css with explicit CSS rule. |
| rspack/unplugin-auto-import/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/type-reexports-presence/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/ts-checker-rspack-plugin/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/treeshaking-transform-imports/rspack.config.js | Replace experiments.css with explicit CSS rule. |
| rspack/treeshaking-transform-imports/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/terser-webpack-plugin/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/tailwindcss/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/tailwindcss-with-type-css/rspack.config.js | Remove experiments.css (relies on CSS rule with type: 'css'). |
| rspack/tailwindcss-with-type-css/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/tailwindcss-postcss/rspack.config.js | Remove experiments.css (relies on CSS rule with type: 'css'). |
| rspack/tailwindcss-postcss/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/svgr/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/svelte/rspack.config.js | Replace experiments.css with explicit CSS rule. |
| rspack/svelte/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/styled-components/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/stats/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/source-map-with-vscode-debugging/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/solid/rspack.config.js | Remove experiments.css (config already has CSS rules). |
| rspack/solid/package.json | Move CLI to devDeps and bump to v2 beta; add dev-server. |
| rspack/sentry/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/rspack-manifest-plugin/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/react/rspack.config.js | Replace experiments.css with explicit CSS rule. |
| rspack/react/package.json | Move CLI to devDeps and bump to v2 beta; add dev-server. |
| rspack/react-with-sass/rspack.config.js | Remove experiments.css (sass rule already uses type: 'css'). |
| rspack/react-with-sass/package.json | Move CLI to devDeps and bump to v2 beta; add dev-server. |
| rspack/react-with-less/rspack.config.js | Remove experiments.css (less rule already uses type: 'css'). |
| rspack/react-with-less/package.json | Move CLI to devDeps and bump to v2 beta; add dev-server. |
| rspack/react-with-extract-css/package.json | Move CLI to devDeps and bump to v2 beta; add dev-server. |
| rspack/react-ssr-esm/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/react-refresh/rspack.config.js | Replace experiments.css with explicit CSS rule. |
| rspack/react-refresh/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/react-refresh-esm/rspack.config.js | Remove experiments.css, add explicit CSS rule; minor string quote normalization. |
| rspack/react-refresh-esm/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/react-refresh-babel-loader/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/react-compiler-babel/rspack.config.js | Replace experiments.css with explicit CSS rule. |
| rspack/react-compiler-babel/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/react-compiler-babel-ts/rspack.config.js | Replace experiments.css with explicit CSS rule. |
| rspack/react-compiler-babel-ts/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/proxy/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/preact/rspack.config.js | Replace experiments.css with explicit CSS rule. |
| rspack/preact/package.json | Move CLI to devDeps and bump to v2 beta; add dev-server. |
| rspack/preact-refresh/rspack.config.js | Replace experiments.css with explicit CSS rule. |
| rspack/preact-refresh/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/postcss-loader/rspack.config.js | Remove experiments.css; set type: 'css' on the PostCSS rule. |
| rspack/postcss-loader/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/polyfill/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/perfsee/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/node-polyfill/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/node-globals-shim/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/nestjs/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/nest-alias/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/multi-entry/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/monaco-editor-webpack-plugin/rspack.config.js | Replace experiments.css with explicit CSS rule. |
| rspack/monaco-editor-webpack-plugin/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/monaco-editor-ts-react/rspack.config.js | Replace experiments.css with explicit CSS rule; minor formatting fix. |
| rspack/monaco-editor-ts-react/package.json | Move CLI to devDeps and bump to v2 beta; add dev-server. |
| rspack/monaco-editor-js/rspack.config.js | Replace experiments.css with explicit CSS rule. |
| rspack/monaco-editor-js/package.json | Move CLI to devDeps and bump to v2 beta; add dev-server. |
| rspack/module-federation-v1/lib2/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/module-federation-v1/lib1/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/module-federation-v1/app/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/module-federation-v1.5/lib2/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/module-federation-v1.5/lib1/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/module-federation-v1.5/app/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/module-federation-interop/rspack-mf-v1/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/module-federation-interop/rspack-mf-v1.5/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/loader-compat/rspack.config.js | Remove experiments.css (CSS handled via rules). |
| rspack/loader-compat/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/lightingcss-loader/rspack.config.js | Remove experiments.css (CSS handled via lightningcss rule). |
| rspack/lightingcss-loader/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/license-webpack-plugin/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/library-umd/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/library-esm/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/library-cjs/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/inline-enum/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/inline-const/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/inline-const-enum/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/http-import/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/html-webpack-plugin/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/hooks-after-resolve/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/generate-package-json-webpack-plugin/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/extract-license/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/express/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/eslint/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/emotion/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/dll/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/dll-reference/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/css-parser-generator-options/rspack.config.js | Add/adjust CSS rules for v2; remove experiments.css. |
| rspack/css-parser-generator-options/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/css-chunking-plugin/rspack.config.js | Replace experiments.css with explicit CSS rule; config formatting cleanup. |
| rspack/css-chunking-plugin/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/cra/rspack.config.js | Replace experiments.css with explicit CSS rule. |
| rspack/cra/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/cra-ts/rspack.config.js | Replace experiments.css with explicit CSS rule. |
| rspack/cra-ts/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/code-splitting/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/case-sensitive-paths-webpack-plugin/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/bundle-splitting/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/builtin-swc-loader/rspack.config.mjs | Replace experiments.css with explicit CSS rule. |
| rspack/builtin-swc-loader/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/basic/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/basic-ts/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rspack/basic-ts-config/package.json | Bump Rspack deps to v2 beta; add dev-server. |
| rsdoctor/rspack/package.json | Bump Rspack deps to v2 beta; add dev-server. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update Rspack to 2.0.0-beta.2, see https://v2.rspack.rs/guide/migration/rspack_1.x