Delete Utils.canReadGameFiles method#187
Open
Poryg1 wants to merge 2 commits intorpgtkoolmv:masterfrom
Open
Conversation
Delete redundant Utils.canReadGameFiles. What it does is: Take already loaded scripts and try to load the last one again. However, if that script cannot be loaded, then rpg_core.js couldn't be loaded either, so the only thing this function will tell us is what we already know.
Deleted SceneManager.checkFileAccess for redundancy.
Collaborator
|
Thx! But, in fact, this method is not working correctly because the forbidden |
Author
|
Oh, I see, forgot about that one :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this method does is:
However, if the target script cannot be loaded, rpg_core.js cannot be loaded either. And when rpg_core.js is not loaded, Utils.canReadGameFiles cannot be executed.
Therefore this function is completely redundant, since if loading worked perfectly, we will see it, and if not, this function cannot even execute to check for it.
I also removed the code from SceneManager to make sure the game won't crash from removing the utils method.