Skip to content

feat(napi): add slot and V2 shred fields to deshred bindings#727

Open
leafaar wants to merge 1 commit intomasterfrom
str-430/deshred-napi-v2
Open

feat(napi): add slot and V2 shred fields to deshred bindings#727
leafaar wants to merge 1 commit intomasterfrom
str-430/deshred-napi-v2

Conversation

@leafaar
Copy link
Copy Markdown
Contributor

@leafaar leafaar commented Apr 10, 2026

Summary

@leafaar leafaar force-pushed the str-430/deshred-napi-v2 branch from 4dee310 to e004554 Compare April 13, 2026 18:21
@leafaar leafaar marked this pull request as ready for review April 13, 2026 18:21
@leafaar leafaar requested review from WilfredAlmeida, Copilot and lvboudre and removed request for WilfredAlmeida and lvboudre April 13, 2026 18:22
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support in the NodeJS N-API bindings for new deshred proto features (slot update variant, slots request filter, and V2 shred index fields on deshred transaction info).

Changes:

  • Extend deshred update oneof handling to include the slot variant across TS/Rust bindings.
  • Add slots filtering to deshred subscribe request bindings and update related test fixtures.
  • Expose completed data set shred index fields on SubscribeUpdateDeshredTransactionInfo in Rust + TS typings, and bump yellowstone-grpc-proto dependency.

Reviewed changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
yellowstone-grpc-client-nodejs/src/index.ts Maps the new deshred update oneof slot variant into the JS SDK shape.
yellowstone-grpc-client-nodejs/napi/tests/js_types_tests.rs Updates deshred request/update-oneof test structs for new fields.
yellowstone-grpc-client-nodejs/napi/src/lib.rs Updates N-API stream tests/helpers to include the new deshred request slots field.
yellowstone-grpc-client-nodejs/napi/src/js_types.rs Implements conversions for deshred slot oneof variant, deshred request slots map, and new shred index fields on transaction info.
yellowstone-grpc-client-nodejs/napi/src/encoding.rs Updates encoding test data to include new transaction info fields.
yellowstone-grpc-client-nodejs/napi/index.d.ts Updates TypeScript declarations for new deshred request/update/transaction-info fields.
yellowstone-grpc-client-nodejs/napi/Cargo.toml Bumps yellowstone-grpc-proto dependency to 12.2.0.
yellowstone-grpc-client-nodejs/napi/Cargo.lock Lockfile update for yellowstone-grpc-proto 12.2.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread yellowstone-grpc-client-nodejs/napi/src/js_types.rs
Comment thread yellowstone-grpc-client-nodejs/napi/Cargo.toml
Comment thread yellowstone-grpc-client-nodejs/napi/tests/js_types_tests.rs
@leafaar leafaar force-pushed the str-430/deshred-napi-v2 branch from e004554 to 6eee30a Compare April 14, 2026 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants