feat(napi): add slot and V2 shred fields to deshred bindings#727
Open
feat(napi): add slot and V2 shred fields to deshred bindings#727
Conversation
4dee310 to
e004554
Compare
There was a problem hiding this comment.
Pull request overview
Adds support in the NodeJS N-API bindings for new deshred proto features (slot update variant, slots request filter, and V2 shred index fields on deshred transaction info).
Changes:
- Extend deshred update oneof handling to include the
slotvariant across TS/Rust bindings. - Add
slotsfiltering to deshred subscribe request bindings and update related test fixtures. - Expose completed data set shred index fields on
SubscribeUpdateDeshredTransactionInfoin Rust + TS typings, and bumpyellowstone-grpc-protodependency.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| yellowstone-grpc-client-nodejs/src/index.ts | Maps the new deshred update oneof slot variant into the JS SDK shape. |
| yellowstone-grpc-client-nodejs/napi/tests/js_types_tests.rs | Updates deshred request/update-oneof test structs for new fields. |
| yellowstone-grpc-client-nodejs/napi/src/lib.rs | Updates N-API stream tests/helpers to include the new deshred request slots field. |
| yellowstone-grpc-client-nodejs/napi/src/js_types.rs | Implements conversions for deshred slot oneof variant, deshred request slots map, and new shred index fields on transaction info. |
| yellowstone-grpc-client-nodejs/napi/src/encoding.rs | Updates encoding test data to include new transaction info fields. |
| yellowstone-grpc-client-nodejs/napi/index.d.ts | Updates TypeScript declarations for new deshred request/update/transaction-info fields. |
| yellowstone-grpc-client-nodejs/napi/Cargo.toml | Bumps yellowstone-grpc-proto dependency to 12.2.0. |
| yellowstone-grpc-client-nodejs/napi/Cargo.lock | Lockfile update for yellowstone-grpc-proto 12.2.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e004554 to
6eee30a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
slotvariant to deshred update oneof in NAPI bindingsslotsfilter to deshred request