Get proper parameters with prefixes without dot separator#455
Merged
Get proper parameters with prefixes without dot separator#455
Conversation
Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
hidmic
approved these changes
Nov 11, 2019
Contributor
hidmic
left a comment
hidmic
left a comment
There was a problem hiding this comment.
LGTM, can we add a test or do a sanity linter check at least?
Contributor
Author
|
What do you mean by sanity linter? |
Contributor
Even if no tests are available, do a CI run on e.g. Linux to make sure at least linters are passing. |
Member
|
The |
Contributor
|
Oh, that's right. Then go ahead if the ROSBoss approves. |
mjcarroll
approved these changes
Nov 12, 2019
jaisontj
pushed a commit
to aws-ros-dev/rclpy
that referenced
this pull request
Nov 19, 2019
Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
suab321321
pushed a commit
to suab321321/rclpy
that referenced
this pull request
Jan 31, 2020
Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com> Signed-off-by: AbhinavSingh <singhabhinav9051571833@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For parameters without a "." prefix, the code wasn't working as it should. Connected to ros2/ros2cli#389