Added option to delete repositories listed in a YAML file.#40
Added option to delete repositories listed in a YAML file.#40leander-dsouza merged 1 commit intomainfrom
Conversation
0901562 to
f0ca719
Compare
claraberendsen
left a comment
There was a problem hiding this comment.
Left some nitpicks in terms of unifying naming towards directories or paths when given messages to the user.
Overall I think it looks good to me.
I think we should add a test-guard that checks that only the folders specified in the yaml are being deleted since users might have other stuff co-living with repositories managed by vcs.
There was a problem hiding this comment.
What would happen if the YAML is empty?
There was a problem hiding this comment.
You would get the following error:
Error: Failed to read repositories: Input data is not valid format: 'NoneType' object is not subscriptableThis is captured from the following line in delete.py.
973de9b to
093a26a
Compare
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
093a26a to
7daff24
Compare
I have added a few assertions in the integration test to verify the specific deletion of folders over here. |
Basic Info
Description of contribution in a few bullet points
deletecommand forvcsto remove all the paths specified under the YAML repository file.-f/--forceoption is passed:deletefeature.Description of how this change was tested
Ran
pytestlocally to ensure all the unit and linting tests pass:pytest -s -v testCreated a local fork to validate green CI.
Signed-off-by: Leander Stephen Desouza leanderdsouza1234@gmail.com