Fix: UnboundLocalError: local variable 'version_type' referenced before assignment#15
Fix: UnboundLocalError: local variable 'version_type' referenced before assignment#15leander-dsouza merged 1 commit intoros-infrastructure:mainfrom hoffmann-stefan:fix-validate-git-hash
Conversation
|
Thanks @hoffmann-stefan for rebasing the PR. We are looking at cutting a release with was was there and small updates to get CI working first and soon after another one with the long pending community contributions with this PR reviewed in that cycle. |
leander-dsouza
left a comment
There was a problem hiding this comment.
LGTM!
Thank you @hoffmann-stefan for the fix :)
|
@hoffmann-stefan I would like to ask if you can delete the fork you have of this repo now that this is merged. We want to break away from the upstream fork network and having child forks prevents us to do it easily. Any further contribution is always welcomed and once this repo becomes the root of a new fork network. Additionally this change is already available on 1.1.3 version of vcs2l released last week: https://pypi.org/project/vcs2l/1.1.3. |
|
@claraberendsen I did delete my fork. Thanks for the review, merge and release of this fix, we will look forward to use your fork in our tooling :) |
rebased version of dirk-thomas/vcstool#239
ping @furushchev FYI
We use this this fix for our internal codebase. If this is merged we could switch back to an official release.
should fix dirk-thomas/vcstool#271