Skip to content

[DF] Enable RDataFrame exception tests also on macOS #22382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guitargeek wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −3
Open

[DF] Enable RDataFrame exception tests also on macOS #22382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions tree/dataframe/test/dataframe_vary.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,8 @@ TEST(RDFVary, RequireVariationsHaveConsistentType)
std::runtime_error);
}

// throwing exceptions from jitted code cause problems on windows and MacOS+M1
// throwing exceptions from jitted code cause problems on windows
#if !defined(_MSC_VER) || defined(R__ENABLE_BROKEN_WIN_TESTS)
#if !(defined(R__MACOSX) && defined(__arm64__))
TEST(RDFVary, RequireVariationsHaveConsistentTypeJitted)
{
// non-jitted Define, jitted Vary with incompatible type
Expand Down Expand Up @@ -230,7 +229,6 @@ TEST(RDFVaryDeathTest, JitFailureThrowsInsteadOfCrashing)
::testing::ExitedWithCode(0), "");
}
#endif
#endif

TEST(RDFVary, RequireReturnTypeIsRVec)
{
Expand Down
Loading