[ntuple] fix bit truncation on big endian#22358
Merged
Merged
Conversation
jblomer
force-pushed
the
ntuple-fix-bigendian
branch
from
3853662 to
16464fa
Compare
Moves the endianess handling inside BitPacking::[Pack|Unpack]Bits. Fixes truncated and quantized real values on big endian architectures.
Test Results 22 files 22 suites 3d 9h 27m 47s ⏱️ Results for commit 16464fa. |
hahnjo
approved these changes
May 22, 2026
Member
hahnjo
left a comment
hahnjo
left a comment
There was a problem hiding this comment.
LGTM with the discussion offline that it is already byte-swapped, we "only" need to memcpy to the right place.
Contributor
Author
|
/backport to 6.40 |
|
Preparing to backport PR #22358 to branch 6.40 requested by jblomer |
|
This PR has been backported to branch 6.40: #22390 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the endianess handling inside BitPacking::[Pack|Unpack]Bits. Fixes truncated and quantized real values on big endian architectures.
Remaining open point from #10409 (comment)
Verified on POWER8 using the RNTuple validation suite.