Update source-configs.js to allow for empty string to be set from ENV variables#378
Merged
kethinov merged 1 commit intorooseveltframework:mainfrom Mar 11, 2026
Merged
Conversation
Member
|
Thanks! Published to npm as 1.0.1 https://www.npmjs.com/package/source-configs?activeTab=versions |
kethinov
added a commit
that referenced
this pull request
Mar 14, 2026
Same change as #378 to an overlooked line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows for empty string to be set from ENV variables which is different than unsetting the ENV. The original if check would return false because empty string is falsey. The change explicitly checks the process.env JSON to see if the key exists and then sets the variable to whatever is there (which can now be empty string)