Open
Conversation
RomanHristofor
force-pushed
the
ht4-roman-kh
branch
from
2af5b8f to
1412358
Compare
romabelka
reviewed
Dec 3, 2018
| export default connect( | ||
| null, | ||
| (state, props) => ({ | ||
| people: peopleSelector(state).filter((people) => |
Owner
There was a problem hiding this comment.
для этого тоже селектор хорошо бы завести
| try { | ||
| yield call( | ||
| api.addPersonToEventsFb, | ||
| `events/${eventId}/peopleIds`, |
Owner
There was a problem hiding this comment.
Оставь просто eventId, зачем тебе знать ту про пути к рефам?
Author
There was a problem hiding this comment.
Оставь просто eventId, зачем тебе знать ту про пути к рефам?
peopleIds - это филда в айтоме ивентов, в который я делаю set(peopleIds)
из нее же потом и читаю при селекте ивента
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.