Skip to content

fix(node-resolve): error thrown with empty entry #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shellscape merged 3 commits into from
Oct 4, 2025
Merged

fix(node-resolve): error thrown with empty entry #1893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f90770
Fix error thrown with empty entry while using node-resolve plugin
internettrans Aug 18, 2025
fa74e39
Clean up test syntax
internettrans Aug 18, 2025
5f10fda
Formatting
internettrans Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/node-resolve/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ export function nodeResolve(opts = {}) {

const importSpecifierList = [importee];

if (importer === undefined && !importee[0].match(/^\.?\.?\//)) {
if (importer === undefined && importee[0] && !importee[0].match(/^\.?\.?\//)) {
// For module graph roots (i.e. when importer is undefined), we
// need to handle 'path fragments` like `foo/bar` that are commonly
// found in rollup config files. If importee doesn't look like a
Expand Down
12 changes: 12 additions & 0 deletions packages/node-resolve/test/test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,3 +743,15 @@ test('allow other plugins to take over resolution', async (t) => {
]
});
});

test('error message for invalid entry', async (t) => {
const error = await t.throwsAsync(() =>
rollup({
input: '',
onwarn: failOnWarn(t),
plugins: [nodeResolve()]
})
);

t.is(error.message, `Could not resolve entry module "".`);
});
Loading