Skip to content

ci: align release app token usage#82

Merged
Boshen merged 1 commit intomainfrom
codex/fix-release-app-token-usage
Apr 22, 2026
Merged

ci: align release app token usage#82
Boshen merged 1 commit intomainfrom
codex/fix-release-app-token-usage

Conversation

@Boshen
Copy link
Copy Markdown
Member

@Boshen Boshen commented Apr 22, 2026

Summary

  • remove the ineffective owner / repositories inputs from the release GitHub App token step
  • match the same-repo GitHub App token usage used in oxc-project/oxc and oxc-project/unicode-id-start
  • add workflow_dispatch so the release workflow can be manually retested after the GitHub App installation is fixed

Why

The failed run still reached GET /repos/rolldown/notify/installation and returned 404 even with owner and repositories set. The Oxc workflows use plain client-id + private-key for same-repo tokens; the remaining issue is the GitHub App installation or selected-repository access for rolldown/notify, not workflow token scoping.

Verification

  • ruby -e 'require "yaml"; YAML.load_file(".github/workflows/release.yml"); puts "ok"'
  • git diff --check -- .github/workflows/release.yml

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2151b0f5fa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 22 to 24
with:
client-id: ${{ secrets.APP_ID }}
private-key: ${{ secrets.APP_PRIVATE_KEY }}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep GitHub App token scoped to required permissions

By removing the permission-contents and permission-pull-requests inputs from this actions/create-github-app-token step, the minted installation token now defaults to all permissions granted to the app installation, not just the two needed by release-plz. That expands the blast radius for every release run if a downstream action or script is compromised, and it is a security regression relative to the previous least-privilege configuration.

Useful? React with 👍 / 👎.

@Boshen Boshen merged commit 3960b5a into main Apr 22, 2026
8 of 10 checks passed
@Boshen Boshen deleted the codex/fix-release-app-token-usage branch April 22, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant