Skip to content

Revert "ci: use bot PAT for release"#80

Merged
Boshen merged 1 commit intomainfrom
revert-79-codex/fix-release-token
Apr 22, 2026
Merged

Revert "ci: use bot PAT for release"#80
Boshen merged 1 commit intomainfrom
revert-79-codex/fix-release-token

Conversation

@Boshen
Copy link
Copy Markdown
Member

@Boshen Boshen commented Apr 22, 2026

Reverts #79

@Boshen Boshen merged commit aaadbf3 into main Apr 22, 2026
4 checks passed
@Boshen Boshen deleted the revert-79-codex/fix-release-token branch April 22, 2026 05:41
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 96748fa5bb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +19 to +23
- uses: actions/create-github-app-token@1b10c78c7865c340bc4f6099eb2f838309f1e8c3 # v3.1.1
id: app-token
with:
client-id: ${{ secrets.APP_ID }}
private-key: ${{ secrets.APP_PRIVATE_KEY }}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid reinstating unavailable GitHub App token flow

Re-adding actions/create-github-app-token here makes the release job depend on a GitHub App installation for this repo, but this exact step was just removed in the preceding change because it failed with Not Found for repository installation lookup; putting it back will cause release-plz runs on main to fail again before release logic executes whenever the app is still not installed/configured for rolldown/notify.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant