Skip to content

Adapt to https://github.com/rocq-community/micromega-plugin/pull/1 (tify)#251

Open
fajb wants to merge 12 commits intorocq-prover:masterfrom
fajb:tify
Open

Adapt to https://github.com/rocq-community/micromega-plugin/pull/1 (tify)#251
fajb wants to merge 12 commits intorocq-prover:masterfrom
fajb:tify

Conversation

@fajb
Copy link
Copy Markdown
Contributor

@fajb fajb commented Apr 1, 2026

@SkySkimmer
Copy link
Copy Markdown
Contributor

This makes stdlib incompatible with all released versions of rocq

@fajb
Copy link
Copy Markdown
Contributor Author

fajb commented Apr 2, 2026

Yes. What is the workaround?

  • If the stdlib is not modified, the rocq ci fails because of deprecation warnings
  • If the stdlib is updated, this uses things which did not exist

What I see possible is

  • Do not generate deprecation warnings
  • Do not update the stdlib

This is slow.

@SkySkimmer
Copy link
Copy Markdown
Contributor

If the stdlib is not modified, the rocq ci fails because of deprecation warnings

Really? Deprecation warnings should not be fatal though.

Copy link
Copy Markdown
Contributor

@proux01 proux01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we won't be able to merge this until long. I'm offering a solution.

@fajb
Copy link
Copy Markdown
Contributor Author

fajb commented Apr 2, 2026

From what I recall, at least the test-suite checks for the exact results. Warnings makes this fail.

@SkySkimmer
Copy link
Copy Markdown
Contributor

Locally disable the warning then

@fajb
Copy link
Copy Markdown
Contributor Author

fajb commented Apr 2, 2026

Ok, I see. I can try to do that.

@SkySkimmer SkySkimmer changed the title Adapt to rocq-prover/rocq#21842 Adapt to rocq-prover/rocq#21842 (tify) Apr 2, 2026
@andres-erbsen
Copy link
Copy Markdown
Collaborator

My opinion is that we should merge this instead of accruing technical debt to support unexpected combinations of rocq and stdlib. I raised this concern here when the stdlib split was proposed.

@andres-erbsen
Copy link
Copy Markdown
Collaborator

Is this failure also due to compat somehow?

Run NIXPKGS_ALLOW_UNFREE=1 nix-build --no-out-link --argstr bundle "rocq-master" --argstr job "stdlib"
...
[at-level-200-changed,deprecated-since-9.3,deprecated,default]
...
File "./micromega/Tify.v", line 14, characters 13-26:
Error: The reference tify_elim_let was not found in the current environment.

@fajb
Copy link
Copy Markdown
Contributor Author

fajb commented Apr 2, 2026

I silenced globally the zify warnings.

When this is deemed the right time, the stdlib can enable them.

@SkySkimmer
Copy link
Copy Markdown
Contributor

Global seems far too aggressive, please keep warning manipulation local.

@fajb
Copy link
Copy Markdown
Contributor Author

fajb commented Apr 2, 2026

I don´t thing you can because otherwise each call to e.g. lia will be cluttered with warnings.
Removing the warnings means updating the stdlib in an incompatible way.

PS: Another option, no deprecation warnings in the tify PR (for now). When things stabilise, enable them.

@SkySkimmer
Copy link
Copy Markdown
Contributor

That sounds like the warning is badly implemented.

@SkySkimmer
Copy link
Copy Markdown
Contributor

I guess it's a similar problem as rocq-prover/rocq#21877 where the warning should be at intern time not interp time.

proux01 added 9 commits April 6, 2026 14:52
In preparation of move to Corelib.
In preparation of move to Corelib.
In preparation of move to Corelib.
Was purely redundant with eKind
For instance conflicts between two libraries, one that would still be
using the plugin shipped with Rocq and another that uses the new plugin.
proux01 added a commit to proux01/coqutil that referenced this pull request Apr 10, 2026
proux01 added a commit to proux01/coq-elpi that referenced this pull request Apr 13, 2026
proux01 added a commit to proux01/Coq-Equations that referenced this pull request Apr 13, 2026
proux01 added a commit to proux01/bedrock2 that referenced this pull request Apr 13, 2026
restructure components (isolate tify,zify)
proux01 added a commit to proux01/Coq-Equations that referenced this pull request Apr 13, 2026
proux01 added a commit to proux01/bedrock2 that referenced this pull request Apr 13, 2026
proux01 added a commit to proux01/metarocq that referenced this pull request Apr 13, 2026
proux01 added a commit to proux01/smtcoq that referenced this pull request Apr 13, 2026
proux01 added a commit to fajb/coq that referenced this pull request Apr 13, 2026
@proux01 proux01 changed the title Adapt to rocq-prover/rocq#21842 (tify) Adapt to https://github.com/rocq-community/micromega-plugin/pull/1 (tify) Apr 13, 2026
proux01 added a commit to fajb/coq that referenced this pull request Apr 13, 2026
proux01 added a commit to fajb/coq that referenced this pull request Apr 13, 2026
proux01 added a commit to fajb/coq that referenced this pull request Apr 13, 2026
proux01 added a commit to fajb/coq that referenced this pull request Apr 13, 2026
proux01 added a commit to fajb/coq that referenced this pull request Apr 13, 2026
proux01 added a commit to fajb/coq that referenced this pull request Apr 13, 2026
proux01 added a commit to fajb/coq that referenced this pull request Apr 13, 2026
proux01 added a commit to fajb/coq that referenced this pull request Apr 13, 2026
proux01 added a commit to fajb/coq that referenced this pull request Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants