fix: poll async resolutions within the test harness#543
Open
doudou wants to merge 2 commits intotransition-to-runkitfrom
Open
fix: poll async resolutions within the test harness#543doudou wants to merge 2 commits intotransition-to-runkitfrom
doudou wants to merge 2 commits intotransition-to-runkitfrom
Conversation
wvmcastro
approved these changes
Feb 6, 2026
There was a problem hiding this comment.
This refactor was indispensable or "just" an improvement on readability and responsibility?
wvmcastro
reviewed
Feb 6, 2026
Comment on lines
+21
to
+22
| it "finishes within the test the resolutions " \ | ||
| "created during the generation block" do |
There was a problem hiding this comment.
replicate the test for "finishes at the end"
jhonasiv
approved these changes
Feb 6, 2026
wvmcastro
approved these changes
Mar 4, 2026
So far, if code executed during the test called apply_requirement_modifications, the test would have created an async resolution but never resolved it. This interferes with the rest of the test, and in particular if the test relies on connection management (which is "paused" during resolution) Make sure the expectation harness calls async_poll to finish the resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
So far, if code executed during the test called apply_requirement_modifications,
the test would have created an async resolution but never resolved it. This
interferes with the rest of the test, and in particular if the test relies on
connection management (which is "paused" during resolution)
Make sure the expectation harness calls async_poll to finish the resolution