Outline shaded cells: autodetect exterior shade#489
Outline shaded cells: autodetect exterior shade#489
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #489 +/- ##
==========================================
- Coverage 90.66% 90.63% -0.03%
==========================================
Files 183 183
Lines 20004 20008 +4
==========================================
- Hits 18136 18134 -2
- Misses 1868 1874 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
x-sheep
left a comment
x-sheep
left a comment
There was a problem hiding this comment.
Overall this looks good. Before I can merge this, I'd like the test coverage to cover the other case as well (since this is a library function).
| // A line is drawn between two shaded cells with opposite shades, | ||
| // or erased between shaded cells with the same shade. | ||
| // "Cells" outside the grid are treated as having shade 2, | ||
| // unless there is a cross mark between a shaded cell and the exterior, in which case that cell's shade is used as the exterior shade. |
There was a problem hiding this comment.
I'd like this part of the comment to be rewritten. The exterior shade should be treated as the more common case, with the default value of 2 mentioned afterwards. Also, line 908 is currently too long. (we don't have strict lint rules for this, but it currently sticks out compared to the rest)
3 participants
Some people prefer to use yellow for the inside of the loop. This PR allows autodetecting this preference according via a cross mark on the exterior border.