Fix wrong library attribution in the comment for Append To List#96
Merged
GerwinLaagland merged 2 commits intomainfrom May 5, 2026
Merged
Fix wrong library attribution in the comment for Append To List#96GerwinLaagland merged 2 commits intomainfrom
GerwinLaagland merged 2 commits intomainfrom
Conversation
|
🚀 Preview deployed to https://robotframework-RFCP-syllabus-pr-96.surge.sh/robotframework-RFCP-syllabus/ |
GerwinLaagland
approved these changes
May 5, 2026
|
🚀 Preview deployed to https://robotframework-RFCP-syllabus-pr-96.surge.sh/robotframework-RFCP-syllabus/ |
Collaborator
|
Current suggestion is fine. This is late into the syllabus, and advanced concept already. I think it's fine to refer to other libraries. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Append To List is from Collections Library : not BuiltIn Library
https://robotframework.org/robotframework/latest/libraries/Collections.html#Append%20To%20List
The inline comment in chapter-05/02_control_structures.md:297 says Append To List is a BuiltIn keyword, but it actually belongs to the Collections library
(already imported on line 267 of the same example) ,, for a learner, could create confusion about which library each keyword comes from.
if the intent was to say it is a built-in keyword ( a keyword that come with RF without installing any other dependency ) and we want to keep this intent, i have two suggestions :