Add maximum chapter duration cap when splitting by chapter (#1680)#1808
Open
CryptoJones wants to merge 1 commit into
Open
Add maximum chapter duration cap when splitting by chapter (#1680)#1808CryptoJones wants to merge 1 commit into
CryptoJones wants to merge 1 commit into
Conversation
Adds a MaximumFileDuration setting: when splitting audiobooks by chapter, any chapter longer than the configured limit is divided into equal-length parts titled "Chapter (Part N of M)". Wired up in WinForms and Avalonia UIs, persisted in Configuration, and covered by unit tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
|
Thank you for the PR. The feature is scoped well: persistence, pipeline placement after Please address before merge
|
Owner
|
After making the layout fixes, please run classic (winforms) and chardonnay (avalonia) locally to get human eyes on it. AI can sometimes have a hard time getting visual/layout stuff correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MaximumFileDurationconfiguration setting (in seconds, default 0 = disabled)MaximumFileDuration > 0, any chapter longer than the limit is divided into equal-length parts(Part N of M)— e.g.Chapter 3 (Part 1 of 2)Changes
Configuration.PersistentSettings.cs— newMaximumFileDurationpropertyConfiguration.HelpText.cs— help/tooltip text for the new settingDownloadOptions.Factory.cs— newsplitLongChapters()method; called aftercombineShortChapters()in the split-by-chapter pipelineSettingsDialog.Designer.cs/SettingsDialog.AudioSettings.cs— WinForms UI: label + NumericUpDown in the audiobook fixups group, enabled/disabled with the Split by chapter checkboxAudioSettingsVM.cs/Audio.axaml— Avalonia MVVM binding and NumericUpDown row in the split-by-chapter gridDownloadDecryptBookTests.cs— 6 new unit tests forsplitLongChaptersTest plan
splitLongChaptersunit tests pass (no chapter split, exact limit, even split, uneven split, offset preservation, mixed-length list)Closes #1680
🤖 Generated with Claude Code