Fix v850.cspec#4
Open
b1llow wants to merge 13 commits into
Open
Conversation
This is used in rz-ghidra to implement pretty-printing
Member
|
Hmm, ideally we should reduce the amount of the changes in Ghidra code. Is there any other way to deal with this? E.g. in the |
Member
|
@imbillow do you know if this bug is reproducible with the plain Ghidra somehow? Maybe it worth fixing mainstream in that case? |
Rot127
reviewed
Jan 6, 2025
Member
Rot127
left a comment
Rot127
left a comment
There was a problem hiding this comment.
Yeah, changing it upstream makes more sense. They also have the problem:
https://github.com/NationalSecurityAgency/ghidra/blob/2af9fbc6a396a69361a08bb99a4d79f0df627dab/Ghidra/Processors/V850/data/languages/V850.cspec#L67
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.